diff options
| author | Tim Bielawa <tbielawa@redhat.com> | 2016-10-12 12:53:19 -0700 |
|---|---|---|
| committer | Tim Bielawa <tbielawa@redhat.com> | 2016-10-12 12:53:23 -0700 |
| commit | 70732ee8eb65921a3cce20905a13d30ecc37cf5c (patch) | |
| tree | 518a548c3e9b86d0c331ed335acc1e9379d9403e | |
| parent | c02d227bc2fb34f53bd5dc08da17ad7b8b0a9e4f (diff) | |
| download | openshift-70732ee8eb65921a3cce20905a13d30ecc37cf5c.tar.gz openshift-70732ee8eb65921a3cce20905a13d30ecc37cf5c.tar.bz2 openshift-70732ee8eb65921a3cce20905a13d30ecc37cf5c.tar.xz openshift-70732ee8eb65921a3cce20905a13d30ecc37cf5c.zip | |
Fix missing play assignment in a-o-i callback plugin
If a task fails in the quick installer it calls the
`v2_runner_on_failed` method in the callback plugin. I missed setting
`self._play` in the first iteration of the callback plugin, which it
turns out is critical for the `on_failed` method to work. This fixes
that by adding back in the assignment in the `play_start` method.
| -rw-r--r-- | callback_plugins/openshift_quick_installer.py | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/callback_plugins/openshift_quick_installer.py b/callback_plugins/openshift_quick_installer.py index e2f125df9..fc9bfb899 100644 --- a/callback_plugins/openshift_quick_installer.py +++ b/callback_plugins/openshift_quick_installer.py @@ -1,4 +1,4 @@ -# pylint: disable=invalid-name,protected-access,import-error,line-too-long +# pylint: disable=invalid-name,protected-access,import-error,line-too-long,attribute-defined-outside-init # This program is free software: you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -112,6 +112,8 @@ role. Only the tasks directly assigned to a play are exposed in the else: msg = "PLAY [%s]" % name + self._play = play + self.banner(msg) # pylint: disable=unused-argument,no-self-use |