diff options
| author | Andrew Butcher <abutcher@redhat.com> | 2017-05-15 15:48:46 -0400 |
|---|---|---|
| committer | Andrew Butcher <abutcher@redhat.com> | 2017-05-15 15:51:43 -0400 |
| commit | 75c752d08f63852db6ba4df5f2c4380ba4bcbdc8 (patch) | |
| tree | ff2a6a4a2bb7496d6e37a0bcd43c7a6fb592767e | |
| parent | 47771c9270d3d3dbee4cc7e350efec479f86ecfa (diff) | |
| download | openshift-75c752d08f63852db6ba4df5f2c4380ba4bcbdc8.tar.gz openshift-75c752d08f63852db6ba4df5f2c4380ba4bcbdc8.tar.bz2 openshift-75c752d08f63852db6ba4df5f2c4380ba4bcbdc8.tar.xz openshift-75c752d08f63852db6ba4df5f2c4380ba4bcbdc8.zip | |
Filter non-strings from the oc_adm_ca_server_cert hostnames parameter.
This allows the omit filter to be used in the hostnames parameter list
which simplifies conditionally added hostnames.
| -rw-r--r-- | roles/lib_openshift/library/oc_adm_ca_server_cert.py | 8 | ||||
| -rw-r--r-- | roles/lib_openshift/src/ansible/oc_adm_ca_server_cert.py | 4 | ||||
| -rw-r--r-- | roles/lib_openshift/src/class/oc_adm_ca_server_cert.py | 4 |
3 files changed, 16 insertions, 0 deletions
diff --git a/roles/lib_openshift/library/oc_adm_ca_server_cert.py b/roles/lib_openshift/library/oc_adm_ca_server_cert.py index 03d3e17c4..a6273cfe4 100644 --- a/roles/lib_openshift/library/oc_adm_ca_server_cert.py +++ b/roles/lib_openshift/library/oc_adm_ca_server_cert.py @@ -1534,6 +1534,10 @@ class CAServerCert(OpenShiftCLI): def run_ansible(params, check_mode): '''run the idempotent ansible code''' + # Filter non-strings from hostnames list s.t. the omit filter + # may be used to conditionally add a hostname. + params['hostnames'] = [host for host in params['hostnames'] if isinstance(host, string_types)] + config = CAServerCertConfig(params['kubeconfig'], params['debug'], {'cert': {'value': params['cert'], 'include': True}, @@ -1583,6 +1587,10 @@ class CAServerCert(OpenShiftCLI): # -*- -*- -*- Begin included fragment: ansible/oc_adm_ca_server_cert.py -*- -*- -*- + +# pylint: disable=wrong-import-position +from ansible.module_utils.six import string_types + def main(): ''' ansible oc adm module for ca create-server-cert diff --git a/roles/lib_openshift/src/ansible/oc_adm_ca_server_cert.py b/roles/lib_openshift/src/ansible/oc_adm_ca_server_cert.py index 10f1c9b4b..fc394cb43 100644 --- a/roles/lib_openshift/src/ansible/oc_adm_ca_server_cert.py +++ b/roles/lib_openshift/src/ansible/oc_adm_ca_server_cert.py @@ -1,6 +1,10 @@ # pylint: skip-file # flake8: noqa + +# pylint: disable=wrong-import-position +from ansible.module_utils.six import string_types + def main(): ''' ansible oc adm module for ca create-server-cert diff --git a/roles/lib_openshift/src/class/oc_adm_ca_server_cert.py b/roles/lib_openshift/src/class/oc_adm_ca_server_cert.py index cf99a6584..37a64e4ef 100644 --- a/roles/lib_openshift/src/class/oc_adm_ca_server_cert.py +++ b/roles/lib_openshift/src/class/oc_adm_ca_server_cert.py @@ -96,6 +96,10 @@ class CAServerCert(OpenShiftCLI): def run_ansible(params, check_mode): '''run the idempotent ansible code''' + # Filter non-strings from hostnames list s.t. the omit filter + # may be used to conditionally add a hostname. + params['hostnames'] = [host for host in params['hostnames'] if isinstance(host, string_types)] + config = CAServerCertConfig(params['kubeconfig'], params['debug'], {'cert': {'value': params['cert'], 'include': True}, |