diff options
author | OpenShift Merge Robot <openshift-merge-robot@users.noreply.github.com> | 2017-09-19 11:10:50 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2017-09-19 11:10:50 -0700 |
commit | a53bbdece37475859be68d3878f9d6811835b025 (patch) | |
tree | dd14e4cb4fc66979ecf23387c00ca7b77ffe5db6 /playbooks/byo/openshift-loadbalancer | |
parent | b55ebb3088ffbe13361ac821dc872697fe34820a (diff) | |
parent | f6011f0c805f308a99378d46873b1dbf33ad571f (diff) | |
download | openshift-a53bbdece37475859be68d3878f9d6811835b025.tar.gz openshift-a53bbdece37475859be68d3878f9d6811835b025.tar.bz2 openshift-a53bbdece37475859be68d3878f9d6811835b025.tar.xz openshift-a53bbdece37475859be68d3878f9d6811835b025.zip |
Merge pull request #5274 from sosiouxme/20170828-checks-save-results
Automatic merge from submit-queue
openshift_checks: enable writing results to files
An iteration on how to record check results in a directory structure readable by machines and humans.
Some refactoring of checks and the action plugin to enable writing files
locally about the check operation and results, if the user wants them.
This is aimed at enabling persistent and machine-readable results from
recurring runs of health checks.
Now, rather than trying to build a result hash to return from running
each check, checks can just register what they need to as they're going
along, and the action plugin processes state when the check is done.
Checks can register failures, notes about what they saw, and arbitrary
files to be saved into a directory structure where the user specifies.
If no directory is specified, no files are written.
At this time checks can still return a result hash, but that will likely
be refactored away in the next iteration.
Multiple failures can be registered without halting check execution.
Throwing an exception or returning a hash with "failed" is registered as
a failure.
execute_module now does a little more with the results. Results are
automatically included in notes and written individually as files.
"changed" results are propagated. Some json results are decoded.
A few of the checks were enhanced to use these features; all get some of
the features for free.
Action items:
- [x] Provide a way for user to specify an output directory where they want results written
- [x] Enable a check to register multiple failures and not have to assemble them in result
- [x] Enable a check to register "notes" that will be saved to files but not displayed
- [x] Have module invocations recorded individually as well as in notes
- [x] Enable a check to register files (logs, etc.) from remote host that are to be copied to output dir
- [x] Enable a check to register arbitrary file contents that are to be written to output
- [ ] Take advantage of these features where possible in checks
(Last item done somewhat, more should happen as we go along...)
Diffstat (limited to 'playbooks/byo/openshift-loadbalancer')
0 files changed, 0 insertions, 0 deletions