diff options
| author | Russell Teague <rteague@redhat.com> | 2017-01-25 14:29:15 -0500 |
|---|---|---|
| committer | Russell Teague <rteague@redhat.com> | 2017-01-25 14:29:15 -0500 |
| commit | 83ec5ce228c769fd7252600961fa5b142af00cd9 (patch) | |
| tree | c94d2bad8e15e3279afe963f14312e81af194c4f /playbooks/common/openshift-node | |
| parent | d8fee0cc8441812cdd5e7aaae815adad7a9bbee7 (diff) | |
| download | openshift-83ec5ce228c769fd7252600961fa5b142af00cd9.tar.gz openshift-83ec5ce228c769fd7252600961fa5b142af00cd9.tar.bz2 openshift-83ec5ce228c769fd7252600961fa5b142af00cd9.tar.xz openshift-83ec5ce228c769fd7252600961fa5b142af00cd9.zip | |
Standardize add_host: with name and changed_when
The add_host: task does not change any data on the host and as practice
has been configured to changed_when: False. This commit standardizes
that usage in the byo and common playbooks. Additionally, taks names
are added to each task to improve troubleshooting.
Diffstat (limited to 'playbooks/common/openshift-node')
| -rw-r--r-- | playbooks/common/openshift-node/config.yml | 1 | ||||
| -rw-r--r-- | playbooks/common/openshift-node/service.yml | 10 |
2 files changed, 9 insertions, 2 deletions
diff --git a/playbooks/common/openshift-node/config.yml b/playbooks/common/openshift-node/config.yml index b36c0eedf..308a8959d 100644 --- a/playbooks/common/openshift-node/config.yml +++ b/playbooks/common/openshift-node/config.yml @@ -44,6 +44,7 @@ ansible_become: "{{ g_sudo | default(omit) }}" with_items: "{{ groups.oo_nodes_to_config | default([]) }}" when: hostvars[item].openshift.common is defined and hostvars[item].openshift.common.is_containerized | bool and (item in groups.oo_nodes_to_config and item in groups.oo_masters_to_config) + changed_when: False - name: Configure containerized nodes hosts: oo_containerized_master_nodes diff --git a/playbooks/common/openshift-node/service.yml b/playbooks/common/openshift-node/service.yml index 2da68ceea..130a5416f 100644 --- a/playbooks/common/openshift-node/service.yml +++ b/playbooks/common/openshift-node/service.yml @@ -9,12 +9,18 @@ when: new_cluster_state is not defined - name: Evaluate g_service_nodes - add_host: name={{ item }} groups=g_service_nodes + add_host: + name: "{{ item }}" + groups: g_service_nodes with_items: "{{ oo_host_group_exp | default([]) }}" + changed_when: False - name: Change state on node instance(s) hosts: g_service_nodes connection: ssh gather_facts: no tasks: - - service: name={{ service_type }}-node state="{{ new_cluster_state }}" + - name: Change state on node instance(s) + service: + name: "{{ service_type }}-node" + state: "{{ new_cluster_state }}" |