diff options
| author | Scott Dodson <sdodson@redhat.com> | 2017-07-18 15:10:37 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-07-18 15:10:37 -0400 |
| commit | 8e2be54c6f2f55368f33667a68a5693dc75b1027 (patch) | |
| tree | 0f63035787dce728f9fa994a2dad78cff5bb9f0c /roles/openshift_node_upgrade | |
| parent | 742203529902ba278c213e326f81f667304b9625 (diff) | |
| parent | 5a94fe5b074d01a3b16db8a05c47c31e484e5ebe (diff) | |
| download | openshift-8e2be54c6f2f55368f33667a68a5693dc75b1027.tar.gz openshift-8e2be54c6f2f55368f33667a68a5693dc75b1027.tar.bz2 openshift-8e2be54c6f2f55368f33667a68a5693dc75b1027.tar.xz openshift-8e2be54c6f2f55368f33667a68a5693dc75b1027.zip | |
Merge pull request #4698 from sdodson/service-retries
Service retries
Diffstat (limited to 'roles/openshift_node_upgrade')
| -rw-r--r-- | roles/openshift_node_upgrade/README.md | 5 | ||||
| -rw-r--r-- | roles/openshift_node_upgrade/handlers/main.yml | 20 | ||||
| -rw-r--r-- | roles/openshift_node_upgrade/tasks/docker/upgrade.yml | 8 | ||||
| -rw-r--r-- | roles/openshift_node_upgrade/tasks/restart.yml | 2 |
4 files changed, 30 insertions, 5 deletions
diff --git a/roles/openshift_node_upgrade/README.md b/roles/openshift_node_upgrade/README.md index 8b388cc6a..4e6229bfb 100644 --- a/roles/openshift_node_upgrade/README.md +++ b/roles/openshift_node_upgrade/README.md @@ -84,6 +84,11 @@ Including an example of how to use your role (for instance, with variables passe command: > {{ hostvars[groups.oo_first_master.0].openshift.common.admin_binary }} drain {{ openshift.node.nodename | lower }} --force --delete-local-data --ignore-daemonsets delegate_to: "{{ groups.oo_first_master.0 }}" + register: l_docker_upgrade_drain_result + until: not l_docker_upgrade_drain_result | failed + retries: 60 + delay: 60 + roles: - openshift_facts diff --git a/roles/openshift_node_upgrade/handlers/main.yml b/roles/openshift_node_upgrade/handlers/main.yml index cb51416d4..110dfe5ce 100644 --- a/roles/openshift_node_upgrade/handlers/main.yml +++ b/roles/openshift_node_upgrade/handlers/main.yml @@ -1,7 +1,13 @@ --- - name: restart openvswitch - systemd: name=openvswitch state=restarted + systemd: + name: openvswitch + state: restarted when: (not skip_node_svc_handlers | default(False) | bool) and not (ovs_service_status_changed | default(false) | bool) and openshift.common.use_openshift_sdn | bool + register: l_openshift_node_upgrade_stop_openvswitch_result + until: not l_openshift_node_upgrade_stop_openvswitch_result | failed + retries: 3 + delay: 30 notify: - restart openvswitch pause @@ -10,5 +16,13 @@ when: (not skip_node_svc_handlers | default(False) | bool) and openshift.common.is_containerized | bool - name: restart node - systemd: name={{ openshift.common.service_type }}-node state=restarted - when: (not skip_node_svc_handlers | default(False) | bool) and not (node_service_status_changed | default(false) | bool) + systemd: + name: "{{ openshift.common.service_type }}-node" + state: restarted + register: l_openshift_node_upgrade_restart_node_result + until: not l_openshift_node_upgrade_restart_node_result | failed + retries: 3 + delay: 30 + when: + - (not skip_node_svc_handlers | default(False) | bool) + - not (node_service_status_changed | default(false) | bool) diff --git a/roles/openshift_node_upgrade/tasks/docker/upgrade.yml b/roles/openshift_node_upgrade/tasks/docker/upgrade.yml index 416cf605a..ebe87d6fd 100644 --- a/roles/openshift_node_upgrade/tasks/docker/upgrade.yml +++ b/roles/openshift_node_upgrade/tasks/docker/upgrade.yml @@ -26,7 +26,13 @@ - debug: var=docker_image_count.stdout when: docker_upgrade_nuke_images is defined and docker_upgrade_nuke_images | bool -- service: name=docker state=stopped +- service: + name: docker + state: stopped + register: l_openshift_node_upgrade_docker_stop_result + until: not l_openshift_node_upgrade_docker_stop_result | failed + retries: 3 + delay: 30 - name: Upgrade Docker package: name=docker{{ '-' + docker_version }} state=present diff --git a/roles/openshift_node_upgrade/tasks/restart.yml b/roles/openshift_node_upgrade/tasks/restart.yml index 6947223af..f228b6e08 100644 --- a/roles/openshift_node_upgrade/tasks/restart.yml +++ b/roles/openshift_node_upgrade/tasks/restart.yml @@ -19,7 +19,7 @@ state: started register: docker_start_result until: not docker_start_result | failed - retries: 1 + retries: 3 delay: 30 - name: Update docker facts |