diff options
author | Jaroslav Henner <jhenner@redhat.com> | 2015-10-05 21:36:14 +0200 |
---|---|---|
committer | Jaroslav Henner <jhenner@redhat.com> | 2015-10-06 12:13:45 +0200 |
commit | a8666531f6130f4b14c145ddece441328c2e60d4 (patch) | |
tree | 5bb5b06fa8533ee1e57954fa6aa7f3a9371121dd /roles/os_firewall/README.md | |
parent | 9fd4af295a7c88b4c112b9bd500e396a766b3dc0 (diff) | |
download | openshift-a8666531f6130f4b14c145ddece441328c2e60d4.tar.gz openshift-a8666531f6130f4b14c145ddece441328c2e60d4.tar.bz2 openshift-a8666531f6130f4b14c145ddece441328c2e60d4.tar.xz openshift-a8666531f6130f4b14c145ddece441328c2e60d4.zip |
Fix exception handling.
The subcommand of the action was called using os.system. The exit value
of os.system is a 16-bit value. This value was propagated and used as
exit value of the whole `cluster {ACTION}` command without any
modification, resulting in `exit()` being called with value > 255. In
the CPython 2.7 exit(v) with v > 255 behaves like exit(0), which hides
that we had an error during the execution.
This commit removes the error propagation by return value and introduces
using exceptions instead.
Diffstat (limited to 'roles/os_firewall/README.md')
0 files changed, 0 insertions, 0 deletions