From 59dbd6d3dbd3d036119f4aee2203cf191ed68cee Mon Sep 17 00:00:00 2001 From: Samuel Munilla Date: Tue, 12 Jan 2016 14:27:43 -0500 Subject: atomic-openshift-installer: Error handling for unicode hostnames Fix error handling for invalid hostnames. Previously we were trying to print the offending hostname out, which caused errors due to python's handling of unicode strings. Seeing as how the user's input stays on the screen directly above the error there is no need to try and print it and we can avoid this problem entirely. --- utils/src/ooinstall/cli_installer.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/utils/src/ooinstall/cli_installer.py b/utils/src/ooinstall/cli_installer.py index 2b6c9deee..4e30929da 100644 --- a/utils/src/ooinstall/cli_installer.py +++ b/utils/src/ooinstall/cli_installer.py @@ -33,9 +33,7 @@ def is_valid_hostname(hostname): def validate_prompt_hostname(hostname): if '' == hostname or is_valid_hostname(hostname): return hostname - raise click.BadParameter('"{}" appears to be an invalid hostname. ' \ - 'Please double-check this value i' \ - 'and re-enter it.'.format(hostname)) + raise click.BadParameter('Invalid hostname. Please double-check this value and re-enter it.') def get_ansible_ssh_user(): click.clear() -- cgit v1.2.3