From 6d48f9f72d47824e4c7a5dd3d358a5ba2cf62b9b Mon Sep 17 00:00:00 2001 From: Devan Goodwin Date: Mon, 28 Nov 2016 15:21:26 -0400 Subject: Fix invalid embedded etcd fact in etcd upgrade playbook. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1398549 Was getting a different failure here complaining that openshift was not in the facts, as we had not loaded facts for the first master during playbook run. However this check was used recently in upgrade_control_plane and should be more reliable. --- playbooks/common/openshift-cluster/upgrades/etcd/backup.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/playbooks/common/openshift-cluster/upgrades/etcd/backup.yml b/playbooks/common/openshift-cluster/upgrades/etcd/backup.yml index 57d4fe4b6..b7f0267c1 100644 --- a/playbooks/common/openshift-cluster/upgrades/etcd/backup.yml +++ b/playbooks/common/openshift-cluster/upgrades/etcd/backup.yml @@ -1,7 +1,7 @@ - name: Backup etcd hosts: etcd_hosts_to_backup vars: - embedded_etcd: "{{ hostvars[groups.oo_first_master.0].openshift.master.embedded_etcd }}" + embedded_etcd: "{{ groups.oo_etcd_to_config | default([]) | length == 0 }}" timestamp: "{{ lookup('pipe', 'date +%Y%m%d%H%M%S') }}" roles: - openshift_facts -- cgit v1.2.3