From 39a9d188209c50698c6694a655f79e9200914b94 Mon Sep 17 00:00:00 2001 From: Samuel Munilla Date: Mon, 3 Oct 2016 14:29:06 -0400 Subject: a-o-i: Force option should allow reinstall If uninstalled hosts were in detected in an environment, the installer could get into a hung state that a user could not easily recover from. This lets --force do what is more expected. --- utils/src/ooinstall/cli_installer.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/utils/src/ooinstall/cli_installer.py b/utils/src/ooinstall/cli_installer.py index 43b1b3244..347ae7ec9 100644 --- a/utils/src/ooinstall/cli_installer.py +++ b/utils/src/ooinstall/cli_installer.py @@ -751,7 +751,9 @@ def get_hosts_to_run_on(oo_cfg, callback_facts, unattended, force, verbose): hosts_to_run_on.remove(host) # Handle the cases where we know about uninstalled systems - if len(uninstalled_hosts) > 0: + # TODO: This logic is getting hard to understand. + # we should revise all this to be cleaner. + if not force and len(uninstalled_hosts) > 0: for uninstalled_host in uninstalled_hosts: click.echo("{} is currently uninstalled".format(uninstalled_host)) # Fall through -- cgit v1.2.3