From 83ec5ce228c769fd7252600961fa5b142af00cd9 Mon Sep 17 00:00:00 2001 From: Russell Teague Date: Wed, 25 Jan 2017 14:29:15 -0500 Subject: Standardize add_host: with name and changed_when The add_host: task does not change any data on the host and as practice has been configured to changed_when: False. This commit standardizes that usage in the byo and common playbooks. Additionally, taks names are added to each task to improve troubleshooting. --- playbooks/byo/openshift-cluster/upgrades/docker/upgrade.yml | 5 +++-- playbooks/byo/openshift-cluster/upgrades/upgrade_etcd.yml | 4 +++- 2 files changed, 6 insertions(+), 3 deletions(-) (limited to 'playbooks/byo/openshift-cluster/upgrades') diff --git a/playbooks/byo/openshift-cluster/upgrades/docker/upgrade.yml b/playbooks/byo/openshift-cluster/upgrades/docker/upgrade.yml index d337b6f75..6de054937 100644 --- a/playbooks/byo/openshift-cluster/upgrades/docker/upgrade.yml +++ b/playbooks/byo/openshift-cluster/upgrades/docker/upgrade.yml @@ -6,11 +6,12 @@ gather_facts: no tasks: - include_vars: ../../cluster_hosts.yml - - add_host: + - name: Evaluate group l_oo_all_hosts + add_host: name: "{{ item }}" groups: l_oo_all_hosts with_items: "{{ g_all_hosts | default([]) }}" - changed_when: false + changed_when: False - hosts: l_oo_all_hosts gather_facts: no diff --git a/playbooks/byo/openshift-cluster/upgrades/upgrade_etcd.yml b/playbooks/byo/openshift-cluster/upgrades/upgrade_etcd.yml index a365ae994..106dcc12d 100644 --- a/playbooks/byo/openshift-cluster/upgrades/upgrade_etcd.yml +++ b/playbooks/byo/openshift-cluster/upgrades/upgrade_etcd.yml @@ -8,10 +8,12 @@ - always tasks: - include_vars: ../cluster_hosts.yml - - add_host: + - name: Evaluate group l_oo_all_hosts + add_host: name: "{{ item }}" groups: l_oo_all_hosts with_items: "{{ g_all_hosts | default([]) }}" + changed_when: False - name: Create initial host groups for all hosts hosts: l_oo_all_hosts -- cgit v1.2.3